Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ha-tabs-subpage instead of ha-app-layout #91

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Conversation

farmio
Copy link
Member

@farmio farmio commented Jul 30, 2023

Use ha-tabs-subpage and hass-tabs-subpage-data-table

Pros:

  • this fixes the last row of the group monitor being out of the viewport (too low)
  • header is smaller - on mobile even the search bar is at the most top of the viewport
  • supports back button out of the box

Cons:

  • rows are now the default height of 52px instead of 35px - I couldn't find how to change that yet
  • sidebar menu is not shown in mobile view in favour of back button
    Update: This seems to be a non-issue as a side-swipe on mobile (app) should bring up the sidebar anyway
  • No "KNX" header anymore. But I guess users will know what they navigated to anyway.

closes #89

Bildschirmfoto 2023-07-31 um 15 01 40
New (9,5 telegrams / view) Old (13 telegrams / view)
Bildschirmfoto 2023-07-31 um 15 01 04 Bildschirmfoto 2023-07-31 um 15 00 55

@farmio farmio requested a review from marvin-w August 1, 2023 17:05
@farmio farmio merged commit 0bcaa88 into main Aug 4, 2023
2 checks passed
@farmio farmio deleted the hass-tabs-subpage branch August 4, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Back" Button
1 participant