Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treat DPT 5 (pulse) sensor like every other sensor #188

Merged
merged 1 commit into from
Mar 2, 2019
Merged

treat DPT 5 (pulse) sensor like every other sensor #188

merged 1 commit into from
Mar 2, 2019
+6 −19

Conversation

farmio
Copy link
Member

@farmio farmio commented Mar 1, 2019

I'm not sure why pulse was treated differently from every other sensor type. Is there something I didn't think about?

  • removed init from RemoteValueDptValue1Ucount() to inherit group_address_state
  • added 'pulse', 'DPT-5' and '1byte_unsigned' to DPTMap of RemoteValueSensor()

#187

@farmio farmio requested a review from Julius2342 March 1, 2019 13:46
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 89.164% when pulling 92fbe8f on farmio:master into 471ad36 on XKNX:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 89.164% when pulling 92fbe8f on farmio:master into 471ad36 on XKNX:master.

Julius2342
Julius2342 approved these changes Mar 2, 2019
View reviewed changes
Copy link
Collaborator

@Julius2342 Julius2342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes makes sense! Thank you!

@Julius2342 Julius2342 merged commit 843be9d into XKNX:master Mar 2, 2019
@farmio farmio mentioned this pull request Mar 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julius2342 Julius2342 Julius2342 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@farmio @coveralls @Julius2342