Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow covers to be inverted again #414

Merged
merged 3 commits into from
Sep 22, 2020
Merged

Allow covers to be inverted again #414

merged 3 commits into from
Sep 22, 2020

Conversation

marvin-w
Copy link
Member

Allow covers to be inverted again

@coveralls
Copy link

coveralls commented Sep 21, 2020 •
edited

Coverage Status

Coverage remained the same at 91.875% when pulling 88b6a42 on marvin-w:feature/allow_covers_to_be_inverted into 17fefb9 on XKNX:master.

farmio
farmio approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@farmio farmio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Shall we test this or is it enough that invert is tested in RemoteValue* ?

@marvin-w marvin-w force-pushed the feature/allow_covers_to_be_inverted branch from c5ac726 to 88b6a42 Compare September 21, 2020 22:12
@marvin-w
Copy link
Member Author

I checked again. Since invert_position had absolutely no tests I added some.

@marvin-w marvin-w merged commit 0aa8107 into XKNX:master Sep 22, 2020
@marvin-w marvin-w deleted the feature/allow_covers_to_be_inverted branch September 22, 2020 09:01
@farmio farmio mentioned this pull request Sep 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farmio farmio farmio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marvin-w @coveralls @farmio