Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Switch not initialized from StateUpdater #502

Merged
merged 2 commits into from Nov 22, 2020

Conversation

farmio
Copy link
Member

@farmio farmio commented Nov 21, 2020

by moving state to RemoteValue again

Description

Switch.after_update was not called from RemoteValueSwitch.read_state (StateUpdater). Moved Switch.state to RemoteValue again.
Now it should initialize state correctly from HA again.
I also added a bunch of tests that are mostly useless, but who knows, maybe they will be useful in the future.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • The documentation has been adjusted accordingly
  • The changes generate no new warnings
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog
  • The Homeassistant plugin has been adjusted in case of new config options

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.499% when pulling 250137d on farmio:fix-switch-callback into 73e42c0 on XKNX:master.

Copy link
Member

@marvin-w marvin-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@farmio farmio merged commit 406c999 into XKNX:master Nov 22, 2020
@farmio farmio deleted the fix-switch-callback branch November 22, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants