Light implementation to control lights using individual group addresses #508

Lennart99 · 2020-11-24T19:04:41Z

Light implementation to control lights using individual group addresses for red, green, blue and white

Description

This PR adds a light implementation that makes it possible to control RGB and RGBW lights that have separate addresses for red, green, blue and white. I have made this a new class to separate it from the existing code, because the addresses needed are different and I thought it might be better to create new class instead of extending the existing class.

Fixes # (issue)

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist:

I have performed a self-review of my own code
The documentation has been adjusted accordingly
The changes generate no new warnings
Tests have been added that prove the fix is effective or that the feature works
The changes are documented in the changelog
The Homeassistant plugin has been adjusted in case of new config options

example Homeassistant Configuration

xknx:
  light:
    - name: 'LED strip'
      individual_colors:
        white:
          address: '3/0/0'
          state_address: '3/3/0'
          brightness_address: '3/1/0'
          brightness_state_address: '3/3/1'
        green:
          address: '3/0/4'
          state_address: '3/3/4'
          brightness_address: '3/1/4'
          brightness_state_address: '3/3/5'
        blue:
          address: '3/0/6'
          state_address: '3/3/6'
          brightness_address: '3/1/6'
          brightness_state_address: '3/3/7'
        red:
          address: '3/0/2'
          state_address: '3/3/2'
          brightness_address: '3/1/2'
          brightness_state_address: '3/3/3'

it is also possible to switch all colors on/off with only one address

xknx:
  light:
    - name: 'LED strip'
      address: '3/0/0'
      individual_colors:
        white:
          state_address: '3/3/0'
          brightness_address: '3/1/0'
          brightness_state_address: '3/3/1'
        green:
          state_address: '3/3/4'
          brightness_address: '3/1/4'
          brightness_state_address: '3/3/5'
        blue:
          state_address: '3/3/6'
          brightness_address: '3/1/6'
          brightness_state_address: '3/3/7'
        red:
          state_address: '3/3/2'
          brightness_address: '3/1/2'
          brightness_state_address: '3/3/3'

coveralls · 2020-11-24T22:19:17Z

Coverage increased (+0.05%) to 94.821% when pulling b287a60 on Lennart99:master into 30720c7 on XKNX:master.

farmio · 2020-11-25T08:20:08Z

Thanks, this would be a nice addition! 👍
I'll try to do a review later this week.

Lennart99 · 2020-11-26T08:28:22Z

I believe this PR is ready for review now

Lennart99 · 2020-11-29T18:02:59Z

I haved moved the functionality into the Light class and updated the config schemas.
I have tried to keep the schemas in the Homeassistant plugin and the library the same as much as possible.

farmio · 2020-11-29T21:49:53Z

docs/light.md

@@ -27,6 +27,24 @@ The Light object is either a representation of a binary or dimm actor, LED-contr
 - `group_address_tunable_white_state` KNX group address for the current relative color temperature. *DPT 5.001*
 - `group_address_color_temperature` KNX group address to set absolute color temperature. *DPT 7.600*
 - `group_address_color_temperature_state` KNX group address for the current absolute color temperature. *DPT 7.600*
+
+- `group_address_switch_red` KNX group address to switch the red component. *DPT 1.001*
+- `group_address_switch_state_red` KNX group address for the state of the red component. *DPT 1.001*


we usually end with "_state" so it would be group_address_switch_red_state.

Fixed in 56b88cc

farmio · 2020-11-29T21:52:30Z

docs/light.md

+print(light.supports_tunable_white)
+print(light.supports_color_temperature)
+
+# Requesting current state via KNX GROUP WRITE


Suggested change

# Requesting current state via KNX GROUP WRITE

# Requesting current state via KNX GroupValueRead for all _state addresses

Fixed in 56b88cc

farmio · 2020-11-29T22:01:48Z

home-assistant-plugin/custom_components/xknx/schema.py

+            vol.Optional(RED): COLOR_SCHEMA,
+            vol.Optional(GREEN): COLOR_SCHEMA,
+            vol.Optional(BLUE): COLOR_SCHEMA,
+            vol.Optional(WHITE): COLOR_SCHEMA,
            vol.Optional(CONF_COLOR_ADDRESS): cv.string,
            vol.Optional(CONF_COLOR_STATE_ADDRESS): cv.string,


I think red green blue be in an inclusion group (optional white) and
these 3/4 in an exclusion group with color_address. https://alecthomas.github.io/voluptuous/docs/_build/html/voluptuous.html#module-voluptuous.schema_builder

fixed in 56bd1e3
I have tried to put the color addresses in an exclude group, of course without changing existing behaviour. I couldn't add the exclude to both the color and color_state addresses because it would make it impossible to use them both at the same time, as should be possible.

farmio · 2020-11-29T22:02:59Z

xknx/config/schema.py

+            vol.Optional(CONF_RED): COLOR_SCHEMA,
+            vol.Optional(CONF_GREEN): COLOR_SCHEMA,
+            vol.Optional(CONF_BLUE): COLOR_SCHEMA,
+            vol.Optional(CONF_WHITE): COLOR_SCHEMA,


again I think this should share an inclusion group.

fixed in 56bd1e3

farmio · 2020-11-29T22:05:04Z

xknx/devices/light.py

+
+    @property
+    def is_on(self):
+        """Return if light supports color."""


Suggested change

"""Return if light supports color."""

"""Return if light is on."""

thanks for your review, this must have been an error on my side
Fixed in 56b88cc

Lennart99 · 2020-12-04T19:42:52Z

I have updated the schemas to make it possible to omit the normal switch address when the switch addresses for the individual colors are used, it is also possible to use both at the same time. Some example configs are present in the test\config_tests\resources\light folder.

…p addresses for red, green, blue and white

…ess is present in individual_colors

farmio reviewed Nov 29, 2020

View reviewed changes

farmio linked an issue Dec 13, 2020 that may be closed by this pull request

Controlling HDL DALI Gateway #285

Closed

2 tasks

Lennart99 added 12 commits December 17, 2020 17:52

create a light implementation to control lights using individual grou…

233faaf

…p addresses for red, green, blue and white

add RGBLight to config

a95f2f8

add tests for RGBLight

8bf9203

Update Homeassistant plugin to Use RGBLight

47f0ad7

update schema

b31a405

move RGBLight functionality into Light

f0683aa

Update Homeassistant plugin to use individual RGB addresses

0891efc

add documentation for RGBLight

b1bbbd7

rename constructor arguments in Light to end with _state

56b88cc

update schemas to use inclusive and exclusive

56bd1e3

update schemas to make the switch address optional when a switch addr…

01e4716

…ess is present in individual_colors

update tests to work with the updates on upstream

b287a60

farmio merged commit a25648e into XKNX:master Dec 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Light implementation to control lights using individual group addresses #508

Light implementation to control lights using individual group addresses #508

Lennart99 commented Nov 24, 2020 •

edited

coveralls commented Nov 24, 2020 •

edited

farmio commented Nov 25, 2020

Lennart99 commented Nov 26, 2020

Lennart99 commented Nov 29, 2020

farmio Nov 29, 2020

Lennart99 Nov 30, 2020 •

edited

farmio Nov 29, 2020

Lennart99 Nov 30, 2020 •

edited

farmio Nov 29, 2020

Lennart99 Nov 30, 2020 •

edited

farmio Nov 29, 2020

Lennart99 Nov 30, 2020 •

edited

farmio Nov 29, 2020

Lennart99 Nov 30, 2020 •

edited

Lennart99 commented Dec 4, 2020

	# Requesting current state via KNX GROUP WRITE
	# Requesting current state via KNX GroupValueRead for all _state addresses

	"""Return if light supports color."""
	"""Return if light is on."""

Light implementation to control lights using individual group addresses #508

Light implementation to control lights using individual group addresses #508

Conversation

Lennart99 commented Nov 24, 2020 • edited

Description

Type of change

Checklist:

example Homeassistant Configuration

coveralls commented Nov 24, 2020 • edited

farmio commented Nov 25, 2020

Lennart99 commented Nov 26, 2020

Lennart99 commented Nov 29, 2020

farmio Nov 29, 2020

Choose a reason for hiding this comment

Lennart99 Nov 30, 2020 • edited

Choose a reason for hiding this comment

farmio Nov 29, 2020

Choose a reason for hiding this comment

Lennart99 Nov 30, 2020 • edited

Choose a reason for hiding this comment

farmio Nov 29, 2020

Choose a reason for hiding this comment

Lennart99 Nov 30, 2020 • edited

Choose a reason for hiding this comment

farmio Nov 29, 2020

Choose a reason for hiding this comment

Lennart99 Nov 30, 2020 • edited

Choose a reason for hiding this comment

farmio Nov 29, 2020

Choose a reason for hiding this comment

Lennart99 Nov 30, 2020 • edited

Choose a reason for hiding this comment

Lennart99 commented Dec 4, 2020

Lennart99 commented Nov 24, 2020 •

edited

coveralls commented Nov 24, 2020 •

edited

Lennart99 Nov 30, 2020 •

edited

Lennart99 Nov 30, 2020 •

edited

Lennart99 Nov 30, 2020 •

edited

Lennart99 Nov 30, 2020 •

edited

Lennart99 Nov 30, 2020 •

edited