Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change RemoteValue to ABC and typecheck it #536

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

farmio
Copy link
Member

@farmio farmio commented Dec 17, 2020

Description

typecheck xknx/remote_value/remote_value.py

Annotating its children (eg. RemoteValueClimate etc.) requires to also annotate most of the dpt module. I'll save this for later.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • The documentation has been adjusted accordingly
  • The changes generate no new warnings
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog
  • The Homeassistant plugin has been adjusted in case of new config options

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 94.777% when pulling 47487e2 on farmio:typecheck-remote_value into 30720c7 on XKNX:master.

@farmio farmio merged commit f844f43 into XKNX:master Dec 21, 2020
@farmio farmio deleted the typecheck-remote_value branch December 21, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants