Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typecheck io, knxip modules and xknx.py #543

Merged
merged 8 commits into from Dec 27, 2020
Merged

Conversation

farmio
Copy link
Member

@farmio farmio commented Dec 25, 2020

Description

Typechecked io and knxip modules and xknx.py, some code quality and error message improvements.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • The documentation has been adjusted accordingly
  • The changes generate no new warnings
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog
  • The Homeassistant plugin has been adjusted in case of new config options

@coveralls
Copy link

coveralls commented Dec 25, 2020

Coverage Status

Coverage decreased (-0.2%) to 94.443% when pulling c83559a on farmio:typecheck-io into 7352bcf on XKNX:master.

@farmio farmio changed the title Typecheck io module Typecheck io and knxip Dec 26, 2020
@farmio farmio changed the title Typecheck io and knxip Typecheck io, knxip modules and xknx.py Dec 26, 2020
was only really used for tests
@farmio farmio merged commit 89b6959 into XKNX:master Dec 27, 2020
@farmio farmio deleted the typecheck-io branch December 27, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants