Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HA integration: Fix knx.send to not coerce floats to int #550

Merged
merged 1 commit into from Jan 3, 2021

Conversation

farmio
Copy link
Member

@farmio farmio commented Jan 3, 2021

Description

Changed the schema for the knx.send service to accept any value when type: is given. This way string, float, dicts, time etc. can be passed.
When type is not set the behavior is not changed -> coerced to int and treated like raw bytes.

Fixes home-assistant/core#44792

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • The documentation has been adjusted accordingly
  • The changes generate no new warnings
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog
  • The Homeassistant plugin has been adjusted in case of new config options

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.859% when pulling c22199b on farmio:fix-send-service into 01cd0fa on XKNX:master.

@farmio farmio merged commit 9514546 into XKNX:master Jan 3, 2021
@farmio farmio deleted the fix-send-service branch January 3, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KNX.send DTP 9.001 (temperature) conversion not ok
2 participants