Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HA service knx.read #587

Merged
merged 2 commits into from Feb 20, 2021
Merged

HA service knx.read #587

merged 2 commits into from Feb 20, 2021

Conversation

farmio
Copy link
Member

@farmio farmio commented Feb 2, 2021

Description

Add HA service read_request for issuing GroupValueRead requests.

Would "read" be a better name - so we have "send" and "read"? (I thought "read_request" may imply that there is no answer processed form this service.)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • The documentation has been adjusted accordingly
  • The changes generate no new warnings
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog
  • The Homeassistant plugin has been adjusted in case of new config options

@coveralls
Copy link

coveralls commented Feb 3, 2021

Coverage Status

Coverage increased (+0.06%) to 94.916% when pulling 8fe524c on farmio:ha-read-service into 5eae8d6 on XKNX:master.

@farmio farmio changed the title HA service read_request HA service knx.read Feb 17, 2021
@farmio farmio merged commit 2c24206 into XKNX:master Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants