Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option for climate device to expose temperture sensors #595

Merged
merged 10 commits into from Feb 16, 2021

Conversation

spacegaier
Copy link
Contributor

Description

Add support for exposing the current and target temperature as sensors from a climate device.

In regards to the sensor naming: The weather device uses underscores to add the suffix, but in HA that looks bad, so I instead went with spaces. Ideally we would use one approach consistently in the library.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • The documentation has been adjusted accordingly
  • The changes generate no new warnings
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog
  • The Homeassistant plugin has been adjusted in case of new config options

Copy link
Member

@farmio farmio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Only thing to consider is renaming "expose_temperature_sensors" to eg. "create_temperature_sensors".

@coveralls
Copy link

coveralls commented Feb 6, 2021

Coverage Status

Coverage increased (+0.006%) to 94.912% when pulling 2c4cce1 on spacegaier:climate-expose-temps into 7521754 on XKNX:master.

@farmio farmio merged commit afa30c7 into XKNX:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants