Fix Address comparison / ValueReader #636
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Comparing GroupAddress to IndividualAddress raised a TypeError.
In the ValueReader we had a match-all callback for TelegramQueue so when a ValueReader was waiting for a Telegram and eg a
DeviceDescriptorRead
comes in the callbackraised a TypeError and the TelegramQueue stalls (I'm not sure why - could be HA suppressing the Error)
The ValueReader now registers its GroupAddress in the TelegramQueue.Callback (and checks it again in its
telegram_received
function).Fixes home-assistant/core#47735
Type of change
Checklist: