Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move some code in xknx.io module #646

Merged
merged 6 commits into from Apr 2, 2021
Merged

move some code in xknx.io module #646

merged 6 commits into from Apr 2, 2021

Conversation

farmio
Copy link
Member

@farmio farmio commented Mar 28, 2021

Description

  • Moved RequestResponse and its subclasses to a new package: xknx.io.request_response
    It is only imported from tunnel.py (apart from tests and some example code) so I think this should be ok.
    I kept mixing up tunneling.py and tunnel.py in xknx.io

  • Moved ConnectionConfig to a new module xknx.io.connection

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • The documentation has been adjusted accordingly
  • The changes generate no new warnings
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog
  • The Homeassistant plugin has been adjusted in case of new config options

@farmio farmio changed the title move some code in xknx.io move some code in xknx.io module Mar 28, 2021
@coveralls
Copy link

coveralls commented Mar 28, 2021

Coverage Status

Coverage increased (+0.0008%) to 94.714% when pulling 553c69b on farmio:io-refactor into 583ac0c on XKNX:main.

@farmio farmio merged commit ecaa01d into XKNX:main Apr 2, 2021
@farmio farmio deleted the io-refactor branch April 2, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants