Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AUTO mode to HVAC #66

Merged
merged 2 commits into from
Sep 25, 2017
Merged

Add AUTO mode to HVAC #66

merged 2 commits into from
Sep 25, 2017

Conversation

buergi
Copy link
Contributor

@buergi buergi commented Sep 22, 2017

According to KNX specification v2.1 3/7/2 Datapoint Types, section 4.3, DPT 20.102 value 0 is "Auto"

This value is used for example when the climate control is able to use a presence detector which governs the HVAC type.

I have however no idea how the AUTO mode is coded in this strange "non-standardised DP type", maybe if raw[0] & 15 == 0 but I don't know it for sure.

According to KNX specification v2.1 3/7/2 Datapoint Types, section 4.3, DPT 20.102 value 0 is Auto
@Julius2342 Julius2342 self-requested a review September 23, 2017 07:28
Copy link
Collaborator

@Julius2342 Julius2342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buergi : thank you for your PR!

What happens with your climate device if you put it to "auto" ?

May I also ask you to fix the unit tests and add a new one for this behaviour?

As long we do not fully understand how that auto mode works together with the non-standardized DP type we should not return this mode within get_supported_operation_modes (we therefore have to distinguish between the two ways ...) @resoai : May you please crosscheck if your device supports an "auto" mode.

(I also asked knx.org if they have any ideas how that mode works, but did not get any feedback.)

Btw, are you from Munich?

@resoai
Copy link

resoai commented Sep 23, 2017 via email

@TinusK
Copy link

TinusK commented Sep 23, 2017

MDT doesn't have it either :(

@buergi
Copy link
Contributor Author

buergi commented Sep 23, 2017

Yes there is an "Auto" mode, here is extract from the KNX specification, v2.1 3/7/2 Datapoint Types, section 4.3, DPT 20.102
hvac

I use the "Auto" setting with my Busch-Jaeger 6131/21-24

It has a Working mode object (11.19.12 in the manual) which allows to configure the values Comfort/Standby/Economy/Frost protection and a Superimposed operating mode object (11.19.13 in the manual) which additionally allows the Auto (Superimposition inactive) setting.
The idea is to have the presence detector output object coupled (in the same group) with the Working mode object, so that it automatically sets the operation mode to Comfort when I'm at home and back to Eco when I'm gone.
The Superimposed operating mode allows me to override this behavior to a fixed mode, which is independent of by presence, by setting it to anything other than Auto.

So in short: Auto in my setup means comfort when I'm at home, otherwise eco.

@buergi
Copy link
Contributor Author

buergi commented Sep 23, 2017

Regarding the strange non-standardized DPT there is information about the coding in the some manuals, for example here page 91:
grafik

This value does not hold any information about the "auto" mode, maybe this information is somehow encoded in bit 0 of the additional status telegram, also of non-standardized DPT:
grafik

So I think we have to go the way you proposed by announcing the Auto value only for operation_mode not for controller_status.

... und, ja bin aus München.

@coveralls
Copy link

coveralls commented Sep 24, 2017

Coverage Status

Coverage remained the same at ?% when pulling 2e0e99c on buergi:master into 6e2c7bb on XKNX:master.

@Julius2342 Julius2342 changed the base branch from master to hvac-improvements September 25, 2017 06:15
@Julius2342 Julius2342 merged commit 50b596d into XKNX:hvac-improvements Sep 25, 2017
Julius2342 added a commit that referenced this pull request Sep 25, 2017
@Julius2342
Copy link
Collaborator

@buergi : Thank you very much :)

Made a small change: 9fa4b31 and merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants