update siteinfo bloc and 1 question

[alain01]

The test of $block.showgroups should be before the table tag. Why ?
Cause if $block.showgroups == false, the result is a useless empty table in the code.

I have a question on another point :
Why test

        <!-- start group loop -->
        <{foreach item=group from=$block.groups}>

?
Cause there is only the webmasters group displayed, no other group in this bloc.
So, I think this test is useless, I think we should pick up the group webmasters, no need to use a foreach for that.
No ?

[mambax7]

Each block can have multiple groups permitted to see it, incl. the Site Info block, so it's not only the Webmaster. You can easily share the Siteinfo block with Anonymous users, and you can also create new groups and add them there:

[GregMage]

That's not it Michael. Alain talks about the display of information.
To answer your question Alain, there can be several administrator groups! If you make a new group in XOOPS and you give it only one system administration rights (for example "Avatars") then this group is an admin group and it appears in the block. I didn't know it worked like that but after a short search here is the proof:

[alain01]

Yes, you are right, Greg and thank you for the explanation for Michael.
Michael, it's not the group to display the bloc.
Ok Greg, we could have more admins groups like administration rights (for example "Avatars") !

So, I get an answer for my question ! Thank you Greg.

And the modification for the test $block.showgroups, thank you for this 1st aprobation

[GregMage]

Alain,
Can you make the changes also on these files:

• htdocs\themes\xbootstrap\modules\system\blocks\system_block_siteinfo.tpl
• htdocs\modules\system\templates\blocks\system_block_siteinfo.tpl

[alain01]

ok, wait, I add other files in this PR

[GregMage]

Great job, thank you Alain!

[GregMage]

We can validate this PR!