Add torch to setup_requires
& dynamic import to prevent import errors when installing via pip
#514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
When trying to install BasicSR as part of of requirements.txt file, install fails if torch is not already installed
It is required in the setup phase
This behaviour can cause unexpected errors in depending on the pip install order
The Solution
In this PR I added
setup_requires
parameter to indicate that torch is required for the setup phaseBecause torch is required only when building the cuda extensions I moved the import to be dynamic with a clear error message for the user
References