Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING FIX] [torchvision 0.17] Change functional_tensor import #650

Merged
merged 1 commit into from
May 17, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion basicsr/data/degradations.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import torch
from scipy import special
from scipy.stats import multivariate_normal
from torchvision.transforms.functional_tensor import rgb_to_grayscale
from torchvision.transforms.functional import rgb_to_grayscale
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would not be a breaking change if you try both imports:

Suggested change
from torchvision.transforms.functional import rgb_to_grayscale
try:
from torchvision.transforms.functional import rgb_to_grayscale
except ImportError:
from torchvision.transforms.functional_tensor import rgb_to_grayscale


# -------------------------------------------------------------------- #
# --------------------------- blur kernels --------------------------- #
Expand Down