Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR for #56 - Updated NuGet packages #57

Merged
merged 7 commits into from Mar 13, 2019
Merged

PR for #56 - Updated NuGet packages #57

merged 7 commits into from Mar 13, 2019

Conversation

jamesmcroft
Copy link
Member

@jamesmcroft jamesmcroft commented Mar 2, 2019 •
edited

This PR includes a change to the XPlat referenced NuGet packages to update them to the latest supported versions.

Updated packages including:

  • Microsoft.NETCore.UniversalWindowsPlatform to 6.1.9
  • MADE to 0.2.19058.1
  • CommonServiceLocator to 2.0.4
  • MvvmLightLibs to 5.4.1.1
  • Newtonsoft.Json to 12.0.1
  • MS Test to 1.4.0
  • Xamarin.Support to 28.0.0.1

@jamesmcroft
Copy link
Member Author

@tom-made can you take a look at this please?

tom-made
tom-made reviewed Mar 13, 2019
View reviewed changes
Copy link
Collaborator

@tom-made tom-made left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally happy with these changes. @jamesmcroft could you quickly take a look at my question?

XPlat.ApplicationModel/XPlat.ApplicationModel.csproj Show resolved Hide resolved
tom-made
tom-made approved these changes Mar 13, 2019
View reviewed changes
Copy link
Collaborator

@tom-made tom-made left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after commentary

@tom-made tom-made merged commit e871f63 into develop Mar 13, 2019
@tom-made tom-made deleted the nuget-package-update branch March 13, 2019 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-made tom-made tom-made approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamesmcroft @tom-made