Skip to content

Commit

Permalink
Remove extra (and wrong) I2C ByteTimeout setting in DDC code.
Browse files Browse the repository at this point in the history
The DDC code sets the I2C timeouts to VESA standards, except that it had an
extra setting of the ByteTimeout value which was wrong (off by a factor of
50). Removing this should help DDC work on many more monitors. Note that the
Intel driver duplicated these settings, along with the error. Yay for cult
and paste coding.
  • Loading branch information
Keith Packard committed Mar 18, 2007
1 parent f521308 commit 52fccb9
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion hw/xfree86/ddc/xf86DDC.c
Expand Up @@ -344,7 +344,6 @@ DDCRead_DDC2(int scrnIndex, I2CBusPtr pBus, int start, int len)
dev->ByteTimeout = 2200; /* VESA DDC spec 3 p. 43 (+10 %) */
dev->StartTimeout = 550;
dev->BitTimeout = 40;
dev->ByteTimeout = 40;
dev->AcknTimeout = 40;

dev->pI2CBus = pBus;
Expand Down

0 comments on commit 52fccb9

Please sign in to comment.