Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI improvement] Destination account & destination tag flow #18

Closed
WietseWind opened this issue Mar 20, 2020 · 3 comments
Closed

[UI improvement] Destination account & destination tag flow #18

WietseWind opened this issue Mar 20, 2020 · 3 comments
Assignees
Labels
App iOS/Android App

Comments

@WietseWind
Copy link
Member

WietseWind commented Mar 20, 2020

Right now, when sending XRP, first the source account, currency and amount are entered.
After that, the destination is selected (enter account / scan a QR).
Then, one goes to the final screen to enter meta info and ... The destination tag.

That doesn't make sense; the Destination tag is part of the destination so it belongs on the screen where the destination account is entered and selected. It can even be very confusing to end users as they can't find a place to enter the tag when selecting the destination.

Here's what we should do (imo) (screenshots by @thisistriss from the original designs).

image

  • if user originates from pasting/scanning an r-address / x-address WITH destination tag:
    1. Select address
    2. Skip (mockup) destination tag entry popup
    3. Show the tx summary (but with tag DISPLAYED) in the "To" section, with a "edit" icon, triggering the (mockup) destination tag entry popup
  • if user originates from pasting/scanning an r-address WITHOUT destination tag:
    1. Select address
    2. SHOW (mockup) destination tag entry popup, if tag for the account is mandatory: require a tag (next disabled if not entered) and show the "requires a ..." text. If the tag for the account is NOT mandatory, allow entry but also allow NEXT without tag.
    3. Show the tx summary (but with tag DISPLAYED) in the "To" section, with a "edit" icon, triggering the (mockup) destination tag entry popup. Show "No destination tag" with edit icon if none is entered.
@WietseWind WietseWind added the App iOS/Android App label Mar 20, 2020
@WietseWind WietseWind changed the title [UI improvement] Group destination account & destination tag to same screen/flow [UI improvement] Destination account & destination tag flow Mar 20, 2020
@N3TC4T N3TC4T moved this from Backlog (or wait for another release) to Working on in XUMM 0.X, 1.X & 2.1 Apr 6, 2020
@WietseWind WietseWind moved this from Working on to Selected for next release in XUMM 0.X, 1.X & 2.1 Apr 6, 2020
@WietseWind WietseWind moved this from Suggested to Planned in V3 (Milestone release) Apr 6, 2020
@WietseWind
Copy link
Member Author

image
^^ States:

  1. No tag required (so not asked with overlay after NEXT on destination selection): Button: [Add destination tag]
  2. Destination tag already entered: Show tag + [ Edit Destination tag]

@WietseWind
Copy link
Member Author

Note

When scanning a QR code with a destination address, and possibly tag: DIRECTLY open the tag panel, as selecting the result is not required anyway since there will only be one address in the scanned QR. If the tag is in the scanned QR as well: prefilled, but still show the tag panel.

@N3TC4T N3TC4T moved this from Selected for next release to Test in XUMM 0.X, 1.X & 2.1 Apr 8, 2020
@WietseWind WietseWind moved this from Test to Ready for release / Released in XUMM 0.X, 1.X & 2.1 Apr 22, 2020
@WietseWind WietseWind moved this from Ready for release / Released to Test in XUMM 0.X, 1.X & 2.1 Apr 22, 2020
@WietseWind WietseWind removed this from Planned in V3 (Milestone release) Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App iOS/Android App
Projects
XUMM 0.X, 1.X & 2.1
  
Released (0.4.X)
Development

No branches or pull requests

3 participants