New subscription manager #1071
Merged
New subscription manager #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cindyyan317
requested review from
godexsoft and
kuznetsss
and removed request for
godexsoft
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1071 +/- ##
===========================================
+ Coverage 53.68% 54.09% +0.40%
===========================================
Files 191 203 +12
Lines 10150 10286 +136
Branches 5417 5452 +35
===========================================
+ Hits 5449 5564 +115
- Misses 3390 3399 +9
- Partials 1311 1323 +12 ☔ View full report in Codecov by Sentry. |
kuznetsss
requested changes
Jan 5, 2024
kuznetsss
requested changes
Jan 5, 2024
godexsoft
requested changes
Jan 5, 2024
kuznetsss
reviewed
Jan 8, 2024
Rebase Fix clang-tidy Fix format Fix compilation Fix Fix ut
godexsoft
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SubscriptionManager is puffy now, containing all the subscribers management and feed generation work. It is hard to implement api_version up to it.
This PR will:
1 Separate each stream to the different feed class for better maintainability and testability, each feed focus on its own feed generation.
2 SubscriptionManager is a dispatcher class now. The API keeps the same as before, except additional api_version parameter for transaction stream.
-RPC engine and web server remove the SubscriptionManager dependency.
-Executor is injected to SubscriptionManager, remove the waiting from unittests code.
3 Utilize boost/signal2 for sub/unsub/pub
4 Implement api_version
5 Remove cleanup from SubscriptionManager, the subscription will be removed as the web session gone.
6 Keep the original log + log when session removed to better track lifespan
7 Fix issue: Duplicated feed sent if multiple watched accounts get affected in same tx.