Skip to content

Commit

Permalink
Address feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
miguelportilla committed Jul 18, 2019
1 parent 85da4d4 commit 72a1799
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/ripple/app/misc/SHAMapStoreImp.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
#include <ripple/core/ConfigSections.h>
#include <ripple/nodestore/impl/DatabaseRotatingImp.h>

#include <boost/beast/core/string.hpp>

namespace ripple {
void SHAMapStoreImp::SavedStateDB::init (BasicConfig const& config,
std::string const& dbName)
Expand Down Expand Up @@ -182,7 +184,8 @@ SHAMapStoreImp::SHAMapStoreImp(
}

// RocksDB only. Use sensible defaults if no values specified.
if (boost::iequals(get<std::string>(section, "type"), "RocksDB"))
if (boost::beast::detail::iequals(
get<std::string>(section, "type"), "RocksDB"))
{
if (!section.exists("cache_mb"))
{
Expand Down
3 changes: 3 additions & 0 deletions src/ripple/nodestore/impl/DatabaseShardImp.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,9 @@ DatabaseShardImp::init()
if ((maxDiskSpace_ << 30) < maxDiskSpace_)
return fail("'max_size_gb' overflow");

// Convert to bytes
maxDiskSpace_ <<= 30;

if (section.exists("ledgers_per_shard"))
{
// To be set only in standalone for testing
Expand Down

1 comment on commit 72a1799

@mellery451
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Please sign in to comment.