Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bassert and treatment of assert in general #251

Closed
vinniefalco opened this issue Jan 8, 2014 · 1 comment
Closed

Fix bassert and treatment of assert in general #251

vinniefalco opened this issue Jan 8, 2014 · 1 comment

Comments

@vinniefalco
Copy link
Contributor

There is a lack of discipline with assert and bassert. Sometimes they get compiled in sometimes they don't. "bassertfalse" in particular behaves oddly. We need to define and enforce a standard for asserting, and make sure that the application behaves predictably.
@rec rec self-assigned this Aug 10, 2015
rec pushed a commit to rec/rippled that referenced this issue Sep 9, 2015
@zaphoyd
Merge pull request XRPLF#251 from jefferai/0.3.x-cmake
17083a4 
Add missing condition_variable include
@vinniefalco
Copy link
Contributor Author

Use BOOST_ASSERT. Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rec @vinniefalco