Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vl method should return public key (Version: 1.5.0) #3392

Closed
mDuo13 opened this issue May 7, 2020 · 0 comments
Closed

vl method should return public key (Version: 1.5.0) #3392

mDuo13 opened this issue May 7, 2020 · 0 comments
Labels
API Change Feature Request Used to indicate requests to add new features Good First Issue Great issue for a new contributor

Comments

@mDuo13
Copy link
Collaborator

mDuo13 commented May 7, 2020

Summary

The recently-added /vl/{pubkey} method (#3072) should include a public_key field in the response to be consistent with vl.ripple.com.

Motivation

It would be nice if the vl method were exactly comparable to the format served from vl.ripple.com, for two reasons:

  • Consistency makes things easier to understand.
  • If someone needed to publish their own validator list, they could use a rippled server with a valid TLS key, or pool thereof, to publish the validator list. This reduces the amount of unique infrastructure strictly necessary to run the network.

Solution

When you use the /vl/ method of a rippled server, the resulting JSON object should have the exact same fields as vl.ripple.com. The only difference, currently, is the public_key field, which is known from the request URL but not copied back in rippled's response.

@mDuo13 mDuo13 added API Change Good First Issue Great issue for a new contributor Feature Request Used to indicate requests to add new features labels May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Change Feature Request Used to indicate requests to add new features Good First Issue Great issue for a new contributor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant