Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rippled do not return error for malformed inputs to optional parameters] (Version: [1.11.0-rc2]) #4543

Closed
mounikakun opened this issue May 26, 2023 · 2 comments
Closed

[Rippled do not return error for malformed inputs to optional parameters] (Version: [1.11.0-rc2]) #4543

mounikakun opened this issue May 26, 2023 · 2 comments
Labels
API Change Good First Issue Great issue for a new contributor Will Need Documentation

Comments

@mounikakun
Copy link
Collaborator

Issue Description

In most of the APIs, rippled do not validate inputs for optional parameters like binary, forward, strict etc.

Steps to Reproduce

Expected Result

invalidParamserror

Actual Result

No error

Environment

Supporting Files
@mounikakun
Copy link
Collaborator Author

Issue exists in account_tx

@mounikakun
Copy link
Collaborator Author

mounikakun commented May 30, 2023 •
edited

Issue exists for transactions in noripple_check, binary in tx.

@PeterChen13579 PeterChen13579 mentioned this issue Jul 5, 2023
Closed
@PeterChen13579 PeterChen13579 mentioned this issue Jul 12, 2023
Merged
ckeshava pushed a commit to ckeshava/rippled that referenced this issue Sep 22, 2023
@PeterChen13579 @ckeshava
APIv2(account_tx, noripple_check): return error on invalid input (XRP…
23d0991 
…LF#4620)

For the `account_tx` and `noripple_check` methods, perform input
validation for optional parameters such as "binary", "forward",
"strict", "transactions". Previously, when these parameters had invalid
values (e.g. not a bool), no error would be returned. Now, it returns an
`invalidParams` error.

* This updates the behavior to match Clio
  (https://github.com/XRPLF/clio).
* Since this is potentially a breaking change, it only applies to
  requests specifying api_version: 2.
* Fix XRPLF#4543.
ckeshava pushed a commit to ckeshava/rippled that referenced this issue Sep 25, 2023
@PeterChen13579 @ckeshava
APIv2(account_tx, noripple_check): return error on invalid input (XRP…
47f2407 
…LF#4620)

For the `account_tx` and `noripple_check` methods, perform input
validation for optional parameters such as "binary", "forward",
"strict", "transactions". Previously, when these parameters had invalid
values (e.g. not a bool), no error would be returned. Now, it returns an
`invalidParams` error.

* This updates the behavior to match Clio
  (https://github.com/XRPLF/clio).
* Since this is potentially a breaking change, it only applies to
  requests specifying api_version: 2.
* Fix XRPLF#4543.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Change Good First Issue Great issue for a new contributor Will Need Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@intelliot @mounikakun