Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependency for NuDB ExternalProject #2703

Closed
wants to merge 1 commit into from
Closed

Add dependency for NuDB ExternalProject #2703

wants to merge 1 commit into from

Conversation

mellery451
Copy link
Contributor

No description provided.

ximinez
ximinez approved these changes Oct 3, 2018
View reviewed changes
Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build issues with cmake 3.10.x resolved! Pass, pending CI to confirm the rpm build works. 👍

@ripplelabs-jenkins
Copy link
Collaborator

ripplelabs-jenkins commented Oct 3, 2018 •
edited

Jenkins Build Summary

Built from this commit

Built at 20181003 - 21:08:15

Test Results

Build Type Log Result Status
msvc.Debug logfile 1034 cases, 0 failed, t: 559s PASS ✅
gcc.Debug
-Dcoverage=ON		 logfile 1037 cases, 0 failed, t: 3m50s PASS ✅
docs logfile 1 cases, 0 failed, t: 0m1s PASS ✅
gcc.Release
-Dassert=ON,
MANUAL_TESTS=true		 logfile 1101 cases, 0 failed, t: 6m6s PASS ✅
msvc.Debug,
NINJA_BUILD=true		 logfile 1034 cases, 0 failed, t: 567s PASS ✅
clang.Debug logfile 1037 cases, 0 failed, t: 3m11s PASS ✅
clang.Debug
-Dunity=OFF		 logfile 1037 cases, 0 failed, t: 2m8s PASS ✅
rpm logfile 1037 cases, 0 failed, t: n/a PASS ✅
gcc.Debug logfile 1037 cases, 0 failed, t: 3m26s PASS ✅
clang.Release
-Dassert=ON		 logfile 1037 cases, 0 failed, t: 5m38s PASS ✅
gcc.Debug
-Dunity=OFF		 logfile 1037 cases, 0 failed, t: 10m59s PASS ✅
gcc.Debug
-Dstatic=OFF		 logfile 1037 cases, 0 failed, t: 3m26s PASS ✅
gcc.Release
-Dassert=ON		 logfile 1037 cases, 0 failed, t: 6m6s PASS ✅
msvc.Debug
-Dunity=OFF		 logfile 1034 cases, 0 failed, t: 1214s PASS ✅
gcc.Debug
-Dstatic=OFF -DBUILD_SHARED_LIBS=ON		 logfile 1037 cases, 0 failed, t: 3m26s PASS ✅
gcc.Debug,
NINJA_BUILD=true		 logfile 1037 cases, 0 failed, t: 3m1s PASS ✅
msvc.Release logfile 1034 cases, 0 failed, t: 403s PASS ✅
clang.Debug
-Dunity=OFF -Dsan=undefined,
PARALLEL_TESTS=false		 logfile 1037 cases, 0 failed, t: 2m26s PASS ✅
clang.Debug
-Dunity=OFF -Dsan=address,
PARALLEL_TESTS=false,
DEBUGGER=false		 logfile 1037 cases, 0 failed, t: 5m46s PASS ✅

@ximinez ximinez mentioned this pull request Oct 4, 2018
Closed
@mellery451 mellery451 mentioned this pull request Oct 4, 2018
Closed
@ximinez ximinez mentioned this pull request Oct 8, 2018
Closed
@mellery451 mellery451 added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Oct 9, 2018
@seelabs
Copy link
Collaborator

seelabs commented Oct 10, 2018

In 1.2.0-b3

@seelabs seelabs closed this Oct 10, 2018
@mellery451 mellery451 deleted the nudb-dep-fix branch October 10, 2018 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ximinez ximinez ximinez approved these changes

Assignees

@ximinez ximinez

Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mellery451 @ripplelabs-jenkins @seelabs @ximinez