Enhance AccountTx unit test #2977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Build SummaryBuilt from this commit Built at 20190725 - 00:29:02 Test Results
|
mellery451
approved these changes
Jun 22, 2019
| { 20, jss::Payment, {jss::AccountRoot}, {}, {jss::AccountRoot}}, | ||
| }; | ||
|
|
||
| BEAST_EXPECT (std::extent<decltype (sanity)>::value == |
There was a problem hiding this comment.
L340 sort of overlaps with this check...I think I like this one better since it verifies against the sanity data
There was a problem hiding this comment.
Good point. Would you prefer that I remove the check on line 340? Or is it okay to leave it?
There was a problem hiding this comment.
I'm weakly in favor or removing L340, but I'm fine either way.
scottschurr
force-pushed
the
account-tx-test
branch
from
e9a3238
to
554dd2d
Compare
|
Rebased to 1.3.0-b6. |
jwbusch
approved these changes
Jul 24, 2019
scottschurr
added
the
Passed
scottschurr
force-pushed
the
account-tx-test
branch
from
554dd2d
to
a96e82d
Compare
|
Squashed and rebased to 1.3.0. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on tickets I found that the account_tx RPC test did not examine all possible returned transaction types. So I'm adding that test.
Additionally, it seems that there are enough unit tests exercising Checks that it is worth moving jtx interfaces for check handling into a central location.