Check privileges of user #3011
Closed
Check privileges of user #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if the script is being run as root or sudo, else exit with message.
|
Thank you for your submission. It will be reviewed soon and submitted for processing in CI. |
mellery451
reviewed
Jul 29, 2019
| @@ -2,6 +2,13 @@ | |||
|
|
|||
| # auto-update script for rippled daemon | |||
|
|
|||
| # Check for sudo/root permissions | |||
| if [ `id -u` -ne 0 ]; then | |||
There was a problem hiding this comment.
it's a nit-pick, but other places here use $(cmd) for subshells, so I guess I would prefer that strictly for consistency (I don't think there is any practical difference in this case, but let me know if I'm wrong...)
There was a problem hiding this comment.
No issues. I can change it for consistency.
|
Thank you for your submission. It will be reviewed soon and submitted for processing in CI. |
mellery451
added
the
Passed
Jenkins Build SummaryBuilt from this commit Built at 20190729 - 21:17:08 Test Results
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the script is being run as root or sudo, else exit with message.