Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find boost policy #3022

Closed
wants to merge 16 commits into from
Closed

Find boost policy #3022

wants to merge 16 commits into from

Conversation

mellery451
Copy link
Contributor

small fix for non-bleeding-edge cmake versions.

miguelportilla and others added 16 commits August 4, 2019 20:01
@miguelportilla @nbougalis
Remove SQLite Validations table
c5a95f1
@miguelportilla @nbougalis
Move shard store init to Application
a02d914
@miguelportilla @nbougalis
Fix shard path detection
9e117b7
@thejohnfreeman @nbougalis
Fix GitLab CI
20cc5df 
- Update Docker image to Boost 1.70
- Bust dependency cache
- Pass `Boost_NO_BOOST_CMAKE` to CMake
@thejohnfreeman @nbougalis
Add support for reserved peer slots:
71cbab7 
This commit allows server operators to reserve slots for specific
peers (identified by the peer's public node identity) and to make
changes to the reservations while the server is operating.

This commit closes #2938
@mellery451 @nbougalis
Travis CI improvements:
17529f5 
FIXES: #2527

* define custom docker image for travis-linux builds based on
  package build image
* add macos builds
* add windows builds (currently allowed to fail)
* improve build and shell scripts as required for the CI envs
* add asio timer latency workaround
* omit several manual tests from TravisCI which cause memory exhaustion
@ximinez @nbougalis
Update appveyor dependencies for boost 1.70
96fb6fa
@scottschurr @nbougalis
Enhance AccountTx unit test
eba505e
@HowardHinnant @nbougalis
Remove unneeded and unused base classes in insight
59edcf8
@seelabs @nbougalis
Enable c++-17
9328b74
@seelabs @nbougalis
Use enums for some parameters in payments:
8ee71c5 
* Use enums for StrandDirection, DebtDirection, and QualityDirection
@seelabs @nbougalis
Remove unused TER code from StrandResult
8aaee11
@movitto @nbougalis
Modernize code and clean up out-of-date or obsolete comments:
4326940 
- Remove references to nodestore ledger index. This was removed
  in f946d7b.
@alloynetworks @nbougalis
Warn if the update script is not executed as root
013545e
@nbougalis
Set version to 1.4.0-b1
1615980
@mellery451
Add policy check to FindBoost
c9eb8c3
@mellery451 mellery451 requested a review from ximinez August 6, 2019 16:55
@mellery451
Copy link
Contributor Author

just to clarify - only c9eb8c3 needs to be reviewed, but this change only makes sense ontop of 1.4-b1 which is not in develop yet.

ximinez
ximinez approved these changes Aug 6, 2019
View reviewed changes
Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with cmake 3.11.1 on Linux. Worked like a charm. The build didn't work because of pending issues in the proposed 1.4.0-b1, but the cmake configuration was fine.

@ripplelabs-jenkins
Copy link
Collaborator

Jenkins Build Summary

Built from this commit

Built at 20190806 - 18:06:31

Test Results

Build Type Log Result Status
msvc.Debug logfile 1178 cases, 0 failed, t: 582s PASS ✅
gcc.Release
-Dassert=ON,
MANUAL_TESTS=true		 logfile 915 cases, 0 failed, t: 5m5s PASS ✅
msvc.Debug,
NINJA_BUILD=true		 logfile 1178 cases, 0 failed, t: 612s PASS ✅
gcc.Debug
-Dcoverage=ON,
TARGET=coverage_report,
SKIP_TESTS=true		 logfile 1178 cases, 0 failed, t: 18m26s PASS ✅
docs,
TARGET=docs		 logfile 1 cases, 0 failed, t: 0m1s PASS ✅
clang.Debug logfile no test results, t: 6s [BAD EXIT] FAIL 🔴
clang.Debug
-Dunity=OFF		 logfile no test results, t: 5s [BAD EXIT] FAIL 🔴
msvc.Debug
-Dunity=OFF		 console no test results, t: n/a [BAD EXIT] FAIL 🔴
gcc.Debug logfile 1178 cases, 0 failed, t: 3m5s PASS ✅
msvc.Release logfile 1178 cases, 0 failed, t: 418s PASS ✅
gcc.Debug
-Dunity=OFF		 logfile 1177 cases, 0 failed, t: 8m49s PASS ✅
clang.Release
-Dassert=ON		 logfile no test results, t: 9s [BAD EXIT] FAIL 🔴
gcc.Release
-Dassert=ON		 logfile 1178 cases, 0 failed, t: 5m4s [BAD EXIT] FAIL 🔴
gcc.Debug
-Dstatic=OFF		 logfile 1178 cases, 0 failed, t: 3m1s PASS ✅
gcc.Debug
-Dstatic=OFF -DBUILD_SHARED_LIBS=ON		 logfile 1178 cases, 0 failed, t: 3m3s PASS ✅
gcc.Debug,
NINJA_BUILD=true		 logfile 1178 cases, 0 failed, t: 2m54s PASS ✅
clang.Debug
-Dunity=OFF -Dsan=address,
PARALLEL_TESTS=false,
DEBUGGER=false		 logfile no test results, t: 6s [BAD EXIT] FAIL 🔴
clang.Debug
-Dunity=OFF -Dsan=undefined,
PARALLEL_TESTS=false		 logfile no test results, t: 6s [BAD EXIT] FAIL 🔴

@mellery451 mellery451 added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Aug 6, 2019
@nbougalis nbougalis mentioned this pull request Aug 19, 2019
Merged
@mellery451 mellery451 deleted the find-boost-policy branch August 19, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ximinez ximinez ximinez approved these changes

Assignees

@ximinez ximinez

Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet