Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix snapShot unshare condition #3032

Closed
wants to merge 2 commits into from
Closed

Fix snapShot unshare condition #3032

wants to merge 2 commits into from

Conversation

HowardHinnant
Copy link
Contributor

Fixes: #3020

@ripplelabs-jenkins
Copy link
Collaborator

ripplelabs-jenkins commented Aug 8, 2019 •
edited

Jenkins Build Summary

Built from this commit

Built at 20190808 - 22:35:45

Test Results

Build Type Log Result Status
msvc.Debug logfile 1178 cases, 0 failed, t: 575s PASS ✅
msvc.Debug,
NINJA_BUILD=true		 logfile 1178 cases, 0 failed, t: 609s PASS ✅
msvc.Debug
-Dunity=OFF		 logfile 1177 cases, 0 failed, t: 1098s PASS ✅
msvc.Release logfile 1178 cases, 0 failed, t: 405s PASS ✅
gcc.Release
-Dassert=ON,
MANUAL_TESTS=true		 logfile 915 cases, 0 failed, t: 4m59s PASS ✅
gcc.Debug
-Dcoverage=ON,
TARGET=coverage_report,
SKIP_TESTS=true		 logfile 1178 cases, 0 failed, t: 16m46s PASS ✅
docs,
TARGET=docs		 logfile 1 cases, 0 failed, t: 0m1s PASS ✅
clang.Debug logfile 1178 cases, 0 failed, t: 2m58s PASS ✅
clang.Debug
-Dunity=OFF		 logfile 1177 cases, 0 failed, t: 11m15s PASS ✅
gcc.Debug logfile 1178 cases, 0 failed, t: 2m58s PASS ✅
gcc.Debug
-Dunity=OFF		 logfile 1177 cases, 0 failed, t: 11m23s PASS ✅
clang.Release
-Dassert=ON		 logfile 1178 cases, 0 failed, t: 5m7s PASS ✅
gcc.Release
-Dassert=ON		 logfile 1178 cases, 0 failed, t: 4m59s PASS ✅
gcc.Debug
-Dstatic=OFF		 logfile 1178 cases, 0 failed, t: 2m57s PASS ✅
gcc.Debug
-Dstatic=OFF -DBUILD_SHARED_LIBS=ON		 logfile 1178 cases, 0 failed, t: 2m57s PASS ✅
gcc.Debug,
NINJA_BUILD=true		 logfile 1178 cases, 0 failed, t: 2m49s PASS ✅
clang.Debug
-Dunity=OFF -Dsan=address,
PARALLEL_TESTS=false,
DEBUGGER=false		 logfile 1177 cases, 0 failed, t: 11m14s PASS ✅
clang.Debug
-Dunity=OFF -Dsan=undefined,
PARALLEL_TESTS=false		 logfile 1177 cases, 0 failed, t: 12m34s PASS ✅

seelabs
seelabs approved these changes Aug 9, 2019
View reviewed changes
Copy link
Collaborator

@seelabs seelabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

miguelportilla
miguelportilla approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@miguelportilla miguelportilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mtrippled
Copy link
Collaborator

LGTM 👍

@mtrippled mtrippled added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Aug 14, 2019
@nbougalis nbougalis mentioned this pull request Aug 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelportilla miguelportilla miguelportilla approved these changes

@seelabs seelabs seelabs approved these changes

@mtrippled mtrippled mtrippled approved these changes

Assignees

@seelabs seelabs

@mtrippled mtrippled

Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SHAMap::snapShot maybe exist an error
5 participants
@HowardHinnant @ripplelabs-jenkins @mtrippled @miguelportilla @seelabs