Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRPFees: Fee setting and handling improvements #4247

Merged
merged 11 commits into from Feb 3, 2023

Commits on Jan 4, 2023

  1. Convert fee voting and protocol messages to use XRPAmounts

    * Introduces amendment `featureXRPFees`
    * Includes Validations, Change transactions, the "Fees" ledger object,
      and subscription messages.
    ximinez committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    1365039 View commit details
    Browse the repository at this point in the history
  2. Improve handling of 0 drop reference fee with TxQ

    * For use with CDBC and sidechain projects that do not want to require
      fees.
    * Note that fee escalation logic is still in place, which may cause the
      open ledger fee to rise if the network is busy. 0 drop transactions
      will still queue, and fee escalation can be effectively disabled by
      modifying the configuration on all nodes.
    ximinez committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    7ff7706 View commit details
    Browse the repository at this point in the history
  3. [FOLD] Review feedback from Nik:

    * Break featureXRPCheck logic into multiple blocks.
    * Change default network reserves to match mainnet.
    * Add a isLegalAmountSigned check
    ximinez committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    8d15137 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ebe3a1c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fdff84d View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. Merge remote-tracking branch 'upstream/develop' into feesettings

    * upstream/develop:
      Add a unit test for invalid memos (XRPLF#4287)
    ximinez committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    d35906c View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. Merge remote-tracking branch 'upstream/develop' into feesettings

    * upstream/develop:
      Make NodeToShardRPC a manual test (XRPLF#4379)
      Update build instructions (XRPLF#4376)
    ximinez committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    8178341 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. Merge remote-tracking branch 'upstream/develop' into feesettings

    * upstream/develop:
      Update BUILD.md (XRPLF#4383)
    ximinez committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    cbfce9a View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Review feedback from @drlongle:

    * Pass `convertCallback` by reference.
    ximinez committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    b2ab073 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Review feedback from @thejohnfreeman:

    * Clarify comments explaining the ttFEE transaction field validation.
    ximinez committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    c76b700 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Configuration menu
    Copy the full SHA
    e7a9e66 View commit details
    Browse the repository at this point in the history