Update comment about return value of LedgerHistory::fixIndex #4574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejohnfreeman
approved these changes
Jun 15, 2023
|
maven was the culprit |
ckeshava
added a commit
to ckeshava/rippled
that referenced
this pull request
Sep 22, 2023
`LedgerHistory::fixIndex` returns `false` if a repair was performed. Fix XRPLF#4572
ckeshava
added a commit
to ckeshava/rippled
that referenced
this pull request
Sep 25, 2023
`LedgerHistory::fixIndex` returns `false` if a repair was performed. Fix XRPLF#4572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #4572.
I believe the existing comment belies it's true purpose.
Type of Change