Update sign-and-submit command to include accepted, broadcast, queued and other fields #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckeshava
changed the title
ckeshava
commented
Jan 5, 2024
| @@ -6216,9 +6216,46 @@ class RPCCall_test : public beast::unit_test::suite | |||
| } | |||
| } | |||
|
|
|||
| void | |||
| testSubmitResponseFields() | |||
There was a problem hiding this comment.
Do I need to modify this unit test to incorporate apiVersion ? Since I'm adding new fields, it shouldn't break backwards compatibility even if an older version of rippled recieves the new output
There was a problem hiding this comment.
Correct, this should not be a breaking change and therefore should not be on the next apiVersion.
…g messages in transactionSubmit
|
intelliot
added
the
Perf impact not expected
13 tasks
|
@ckeshava what's the status of this, from your perspective? |
|
As it stands, I don't have anything else to add to the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Fix #3284
This PR purports to make the response of the submit command identical -- irrespective of whether a binary blob or JSON is provided as input to the command.
Context of Change
The linked issue provides a description of the context of the change, actual and expected behaviors.
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
This change adds
accepted, queued, broadcast and other fieldsthat were originally included in PR #3125libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)Before / After
With this change, the cited example in the bug page (payment transaction from the genesis account) returns the expected behavior i.e.
accepted, broadcastand other fields are returned in the output.