New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional unit tests for testing deletion of trust lines #4886
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tests, however they seem to focus on happy path only. Would be good to add several operations which are meant to fail, by design, and confirm they do fail. e.g. exceeding held amount or trying to set up trust line without authorization.
…line ledger object
…f trust line ledger object" This reverts commit f1813e5.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4886 +/- ##
==========================================
Coverage ? 61.48%
==========================================
Files ? 797
Lines ? 70121
Branches ? 36238
==========================================
Hits ? 43114
Misses ? 19764
Partials ? 7243 ☔ View full report in Codecov by Sentry. |
High Level Overview of Change
This PR includes additional unit tests for testing deletion of trust lines.
Context of Change
The tests verify if the trust lines are removed from the owner directory once the settings are restored to defaults.
Type of Change
.gitignore
, formatting, dropping support for older tooling)API Impact
libxrpl
change (any change that may affectlibxrpl
or dependents oflibxrpl
)No change to APIs