Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional unit tests for testing deletion of trust lines #4886

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

ckeshava
Copy link
Collaborator

High Level Overview of Change

This PR includes additional unit tests for testing deletion of trust lines.

Context of Change

The tests verify if the trust lines are removed from the owner directory once the settings are restored to defaults.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)
    No change to APIs

Copy link
Collaborator

@Bronek Bronek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests, however they seem to focus on happy path only. Would be good to add several operations which are meant to fail, by design, and confirm they do fail. e.g. exceeding held amount or trying to set up trust line without authorization.

@ckeshava
Copy link
Collaborator Author

@Bronek I have added three new unit tests to validate the negative results in 2e0dfce

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@6ac2b70). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4886   +/-   ##
==========================================
  Coverage           ?   61.48%           
==========================================
  Files              ?      797           
  Lines              ?    70121           
  Branches           ?    36238           
==========================================
  Hits               ?    43114           
  Misses             ?    19764           
  Partials           ?     7243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 Needs review
Development

Successfully merging this pull request may close these issues.

None yet

3 participants