Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AMM data to book_changes #4992

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

tequdev
Copy link

@tequdev tequdev commented Apr 16, 2024

High Level Overview of Change

Add AMM data to book_changes, which currently parses only Offer data.

Context of Change

#4952

Type of Change

  • [x ] New feature (non-breaking change which adds functionality)

API Impact

  • [x ] Public API: New feature (new methods and/or new fields)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 84 lines in your changes are missing coverage. Please review.

Project coverage is 76.91%. Comparing base (c88166e) to head (4ef3f7b).

Files Patch % Lines
src/ripple/rpc/BookChanges.h 0.00% 68 Missing and 16 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4992      +/-   ##
===========================================
- Coverage    76.97%   76.91%   -0.06%     
===========================================
  Files         1129     1129              
  Lines       131914   131997      +83     
  Branches     39629    39637       +8     
===========================================
- Hits        101539   101529      -10     
- Misses       24459    24484      +25     
- Partials      5916     5984      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants