-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RippleAPI Docs References to 'Ripple' accounts #600
Comments
Good catch. The docs for RippleAPI/ripple-lib are pulled directly from upstream so the changes will have to go there first. |
Has there been any consideration of rebranding RippleAPI to XrpAPI? @JoelKatz @nbougalis |
Has there been consideration? Absolutely. Have we reached a conclusion about when/how to rename every "ripple" thing to be called XRP something? Not yet. |
Good to hear, thanks!! |
Not everything is "XRP" by the way and just renaming everything "Ripple" to "XRP" just would create the exact same confusion (name of the asset, name of the blockchain...). |
Yeah I understand not everything can be renamed and the great XRP ledger is maintained by ripple hence the name rippled for the version of software in use by validators. The only reason I raised the point above is to ensure we have absolute clarity on what is XRP (or XRPL) and what is maintained (or suggested) by Ripple if that makes sense?? Obviously to provide legal/regulatory clarity. PS I thought the blockchain was named the XRP Ledger? please correct me if I'm wrong. |
https://xrpl.org/xrp.html |
Opened XRPLF/xrpl.js#1023 to fix the "Ripple address" thing in the ripple-lib docs. |
This is done in the latest version |
The JS documentation has multiple references to 'ripple' address rather than XRP address. Consider changing this for consistent terminology. :-)
Examples below:
https://xrpl.org/rippleapi-reference.html#amount
https://xrpl.org/rippleapi-reference.html#getbalances
Counterparty - Optional The Ripple address of the account that owes or is owed the funds (omitted if currency is "XRP" or "drops")
https://xrpl.org/rippleapi-reference.html#getbalancesheet
https://xrpl.org/rippleapi-reference.html#getorders
Address - The Ripple address of the account to get the balance sheet of.
https://xrpl.org/rippleapi-reference.html#getpaths
pathfind.source. address - The Ripple address of the account where funds will come from.
The text was updated successfully, but these errors were encountered: