Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RippleAPI Docs References to 'Ripple' accounts #600

Closed
xrpinnovations opened this issue Jun 18, 2019 · 9 comments
Closed

RippleAPI Docs References to 'Ripple' accounts #600

xrpinnovations opened this issue Jun 18, 2019 · 9 comments

Comments

@xrpinnovations
Copy link

The JS documentation has multiple references to 'ripple' address rather than XRP address. Consider changing this for consistent terminology. :-)

Examples below:

https://xrpl.org/rippleapi-reference.html#amount
https://xrpl.org/rippleapi-reference.html#getbalances

Counterparty - Optional The Ripple address of the account that owes or is owed the funds (omitted if currency is "XRP" or "drops")

https://xrpl.org/rippleapi-reference.html#getbalancesheet
https://xrpl.org/rippleapi-reference.html#getorders

Address - The Ripple address of the account to get the balance sheet of.

https://xrpl.org/rippleapi-reference.html#getpaths

pathfind.source. address - The Ripple address of the account where funds will come from.

@mDuo13
Copy link
Collaborator

mDuo13 commented Jun 19, 2019

Good catch. The docs for RippleAPI/ripple-lib are pulled directly from upstream so the changes will have to go there first.

@xrpinnovations
Copy link
Author

xrpinnovations commented Jun 19, 2019

Has there been any consideration of rebranding RippleAPI to XrpAPI? @JoelKatz @nbougalis

@mDuo13
Copy link
Collaborator

mDuo13 commented Jun 20, 2019

Has there been consideration? Absolutely.

Have we reached a conclusion about when/how to rename every "ripple" thing to be called XRP something? Not yet.

@xrpinnovations
Copy link
Author

Good to hear, thanks!!

@MarkusTeufelberger
Copy link
Contributor

Not everything is "XRP" by the way and just renaming everything "Ripple" to "XRP" just would create the exact same confusion (name of the asset, name of the blockchain...).

@xrpinnovations
Copy link
Author

xrpinnovations commented Jul 14, 2019

Yeah I understand not everything can be renamed and the great XRP ledger is maintained by ripple hence the name rippled for the version of software in use by validators. The only reason I raised the point above is to ensure we have absolute clarity on what is XRP (or XRPL) and what is maintained (or suggested) by Ripple if that makes sense?? Obviously to provide legal/regulatory clarity. PS I thought the blockchain was named the XRP Ledger? please correct me if I'm wrong.

@yxxyun
Copy link

yxxyun commented Jul 14, 2019

https://xrpl.org/xrp.html
Naming section

@mDuo13
Copy link
Collaborator

mDuo13 commented Jul 15, 2019

Opened XRPLF/xrpl.js#1023 to fix the "Ripple address" thing in the ripple-lib docs.

@mDuo13
Copy link
Collaborator

mDuo13 commented Sep 9, 2019

This is done in the latest version

@mDuo13 mDuo13 closed this as completed Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants