fix bug in GenericRequest.to_dict() (#391)

CHANGELOG.md

@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 - Resolve `txnNotFound` error with `send_reliable_submission` when waiting for a submitted malformed transaction
 - Small typing mistake in GenericRequest
+- Fix bug in GenericRequest.to_dict()
 
 ## [1.5.0] - 2022-04-25
 ### Added

tests/unit/models/requests/test_requests.py

@@ -1,10 +1,15 @@
 from unittest import TestCase
 
-from xrpl.models.requests import Fee
+from xrpl.models.requests import Fee, GenericRequest
 
 
 class TestRequest(TestCase):
     def test_to_dict_includes_method_as_string(self):
         tx = Fee()
         value = tx.to_dict()["method"]
         self.assertEqual(type(value), str)
+
+    def test_generic_request_to_dict_sets_command_as_method(self):
+        command = "validator_list_sites"
+        tx = GenericRequest(command=command).to_dict()
+        self.assertDictEqual(tx, {"method": command})

xrpl/models/requests/generic_request.py

@@ -79,8 +79,14 @@ def to_dict(self: GenericRequest) -> Dict[str, Any]:
         """
         # uses self.__dict__ instead of self.__dataclass_fields__.keys(), which is what
         # the other models do, because this model doesn't have any dataclass fields
-        return {
+        dict = {
             key: self._to_dict_elem(getattr(self, key))
             for key in self.__dict__
             if getattr(self, key) is not None
         }
+
+        if "command" in dict:
+            dict["method"] = dict["command"]
+            del dict["command"]
+
+        return dict