feat: add support for XLS-38d #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 11, 2022
mvadari
commented
Aug 2, 2022
Comment on lines
-340
to
+341
| self.assertEqual(encode(test_json), test_binary) | ||
| self.assertEqual(decode(test_binary), test_json) | ||
| self.assertEqual(encode(test_json), test_binary) |
There was a problem hiding this comment.
IMO debugging is easier when the decode test is first
mvadari
commented
Aug 3, 2022
This was referenced Aug 3, 2022
mvadari
changed the title
khancode
previously approved these changes
Aug 19, 2022
mvadari
force-pushed
the
sidechain-2.5
branch
from
5dd1410
to
9fc496b
Compare
JST5000
reviewed
Sep 29, 2022
JST5000
reviewed
Sep 29, 2022
JST5000
reviewed
Sep 29, 2022
JST5000
reviewed
Sep 29, 2022
JST5000
reviewed
Sep 29, 2022
JST5000
reviewed
Sep 29, 2022
JST5000
reviewed
Sep 15, 2023
JST5000
reviewed
Sep 15, 2023
JST5000
reviewed
Sep 15, 2023
JST5000
reviewed
Sep 15, 2023
JST5000
reviewed
Sep 15, 2023
JST5000
reviewed
Sep 15, 2023
JST5000
reviewed
Sep 15, 2023
JST5000
reviewed
Sep 15, 2023
mvadari
changed the title
2 tasks
JST5000
reviewed
Sep 25, 2023
JST5000
approved these changes
Sep 25, 2023
khancode
reviewed
Sep 26, 2023
khancode
reviewed
Sep 27, 2023
khancode
reviewed
Sep 27, 2023
mvadari
changed the title
khancode
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR adds support for the latest version of the sidechain design. It also removes the helper methods that were used for the previous version, since those are no longer needed.
There are 8 new transaction types:
XChainCreateBridge(creates a new cross-chain bridge)XChainModifyBridge(modifies the properties of a cross-chain bridge)XChainCreateClaimID(creates a new cross-chain claim ID)XChainCommit(locks/burns the funds on the source chain)XChainAccountCreateCommit(creates an account on the destination chain)XChainClaim(claims the transfer funds on the destination chain)XChainAddClaimAttestation(submits a claim attestation from a witness server)XChainAddAccountCreateAttestation(submits an account creation attestation from a witness server)Context of Change
sidechain prod release
Type of Change
Before / After
Test Plan
Tests were added for all the new features. CI passes. I'd ideally like #571 to be included in this PR before it's merged, but if it has to wait on the Docker container and is in a separate commit, that's fine.