feat: added ticket_sequence to Transaction class common fields #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nit: this PR should have a name somewhat akin to https://www.conventionalcommits.org/en/v1.0.0/ (see: other PRs) |
JST5000
reviewed
Aug 31, 2022
JST5000
reviewed
Aug 31, 2022
JST5000
reviewed
Aug 31, 2022
JST5000
reviewed
Aug 31, 2022
connorjchen
changed the title
ckniffen
approved these changes
Sep 1, 2022
JST5000
previously requested changes
Sep 1, 2022
intelliot
approved these changes
Sep 1, 2022
|
Maybe consider adding a link to https://xrpl.org/tickets.html somewhere in here? Just a thought |
Co-authored-by: Elliot Lee <github.public@intelliot.com>
Co-authored-by: Elliot Lee <github.public@intelliot.com>
This was referenced Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Added ticket_sequence field to common Transaction class fields
Context of Change
Based on issue "Add common field ticket_sequence to Transaction #413"
Type of Change
Test Plan
Wrote out unit tests