Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clawback #580

Merged
merged 19 commits into from
Jul 31, 2023
Merged

Clawback #580

merged 19 commits into from
Jul 31, 2023

Conversation

shawnxie999
Copy link
Contributor

@shawnxie999 shawnxie999 commented May 31, 2023 •
edited

High Level Overview of Change

New Clawback transaction
New asfAllowClawback account flag

Context of Change

Spec

https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-39d-clawback

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Test Plan

@shawnxie999 shawnxie999 changed the title Clawback [DO NOT MERGE] Clawback May 31, 2023
@shawnxie999 shawnxie999 marked this pull request as ready for review May 31, 2023 21:20
@shawnxie999 shawnxie999 marked this pull request as draft May 31, 2023 21:21
@shawnxie999 shawnxie999 changed the title [DO NOT MERGE] Clawback Clawback Jul 10, 2023
@shawnxie999 shawnxie999 marked this pull request as ready for review July 10, 2023 16:31
@shawnxie999
Copy link
Contributor Author

@mvadari @ckniffen this could be re reviewed now with the tests passing :)

@ckniffen ckniffen merged commit 76a5e97 into XRPLF:master Jul 31, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckniffen ckniffen ckniffen approved these changes

@mvadari mvadari mvadari approved these changes

@jonathanlei jonathanlei jonathanlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shawnxie999 @ckniffen @mvadari @jonathanlei