Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run snippets in CI #602

Merged
merged 18 commits into from
Jun 21, 2023
Merged

test: run snippets in CI #602

merged 18 commits into from
Jun 21, 2023

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Jun 20, 2023

High Level Overview of Change

Title says it all. This PR also fixes some snippets issues and adds a sort to multisign, since that snippet was really flaky.

Context of Change

There was an error in the snippets that wasn't caught.

Type of Change

  • Tests (You added tests for code that already exists, or your new feature included in this PR)

Test Plan

CI passes.

@mvadari mvadari marked this pull request as ready for review June 20, 2023 21:37
Copy link
Collaborator

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I added a note to double check that the 2.0 branch gets the multisign changes when the merge happens)

@mvadari
Copy link
Collaborator Author

mvadari commented Jun 21, 2023

LGTM (I added a note to double check that the 2.0 branch gets the multisign changes when the merge happens)

You can just rebase/merge before the merge to ensure that.

@mvadari mvadari merged commit 8ca6050 into master Jun 21, 2023
17 checks passed
@mvadari mvadari deleted the snippet-ci branch June 21, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants