fix(test): move integration test out from unit tests #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mvadari the diff seems weird? |
ckniffen
approved these changes
Jun 21, 2023
justinr1234
approved these changes
Jun 21, 2023
The diff is fine - I'm mainly moving the file from one folder to another, and moving a file doesn't have any diff. This is just a quick fix, so I didn't assimilate the tests into the existing ones (hence the TODO). |
|
@mvadari These test are written to specific networks to get a specific network id response. Therefore we cannot use the So I would like your opinion on what we should do? @pdp2121 If you can elaborate at all please share. I tried to implement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
There was an integration test that was in the unit test section. This PR moves that over.
Context of Change
The test was added in #520. I noticed that unit tests were suddenly taking much longer to run.
Type of Change
Test Plan
CI passes.