Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing nft_page, ledger_index and ledger_hash fields to requests #604

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

pdp2121
Copy link
Collaborator

@pdp2121 pdp2121 commented Jun 21, 2023

High Level Overview of Change

  • Add ledger_hash and ledger_index to account_nfts, nft_buy_offers, and nft_sell_offers requests.
  • Create LookupByLedgerRequest to clean up ledger_hash and ledger_index which are optional on most request objects.
  • Add nft_page to ledger_entry request.

Closes #467

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Test Plan

Test passed.

@pdp2121 pdp2121 changed the title feat: Add missing ledger_index and ledger_hash fields to requests feat: Add missing nft_page, ledger_index and ledger_hash fields to requests Jun 22, 2023
Copy link
Collaborator

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pdp2121 pdp2121 merged commit 1d51463 into XRPLF:master Jun 26, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ledger_entry filter by nft_page
3 participants