Release: Rebase xrpl-py 2.0 with master #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JST5000
requested review from
ckniffen,
justinr1234,
mvadari,
jonathanlei,
khancode and
pdp2121
ckniffen
reviewed
Jun 28, 2023
JST5000
changed the title
ckniffen
approved these changes
Jun 28, 2023
jonathanlei
approved these changes
Jun 28, 2023
* Refactored wallet class and tests * Fix leading zero for key formatting * Changed from_entropy to take in hex string * Update core keypairs docs * Throw error instead truncate for generate seed with entropy * Refactor test main wallet generation suite
* Added from secret numbers method and tests Co-authored-by: Jackson Mills <aim4math@gmail.com>
* Remove deprecated functions * Fix isort --------- Co-authored-by: Caleb Kniffen <ckniffen@ripple.com>
* rename AccountSetFlag -> AccountSetAsfFlags * add AccountSetFlag enum to represent transaction flags Note: AccountSetAsfFlags are not bit-field flags and therefore do not require a FlagInterface. At most one asf flag can be set per transaction.
* Remove send_reliable_submission
* Update CHANGELOG * Remove aliases
* Update the CHANGELOG * Update `autofill_and_sign` and `sign_and_submit`
…#601) * Remove classic_address from Wallet * Re-add the `classic_address` alias
* fix XRP.to_amount * update changelog * fix circular dependency * fix circular dependency * add comment * fix test * improve comment
* Update CHANGELOG with networkid * Add amount unit test * Add sign_and_submit test * Add test for _calculate_fee_per_transaction_type * Use asyncio.run * Use a valid account address * Update the README with submit_and_wait link
* Fix invalid account address * Add invalid account test * Remove magic address in favor of Wallet.create() * Add classic_address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Rebasing all the changes from xrpl-py-2.0 branch with master
Context of Change
Preparing to release.
Type of Change
Test Plan
CI Passes