fix: Fix classic_address aliasing issue
#617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #616 |
mvadari
reviewed
Jul 6, 2023
| differentiate it from the x-address standard, which encodes the network, | ||
| destination tag, and XRPL address into a single value. It's also a base58 string. | ||
| """ | ||
| # TODO: Just alias classic_address once mypy has resolved this issue: |
There was a problem hiding this comment.
I'd recommend opening an issue for this as a reminder
mvadari
approved these changes
Jul 6, 2023
ckniffen
approved these changes
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Fix mypy complaining about
Wallet.classic_addressbeing aCallablewhen it is an aliasedstrproperty. (Open mypy issue: python/mypy#6700)Context of Change
Currently aliasing a property is not properly typed by mypy. As a workaround you can switch to using
addressinstead ofclassic_address, but this should resolve the issue until the mypy issue is fixed.Type of Change
Test Plan
CI passes