Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update request models related to AMM #638

Merged
merged 6 commits into from
Sep 11, 2023
Merged

fix: update request models related to AMM #638

merged 6 commits into from
Sep 11, 2023

Conversation

khancode
Copy link
Collaborator

@khancode khancode commented Aug 28, 2023 •
edited

High Level Overview of Change

Update request models related to AMM:

  • Add amm to ledger_entry and account_objects
  • Add amm_account to amm_info request and set asset pair params to be optional

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Test Plan

All tests pass.

mvadari
mvadari approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@mvadari mvadari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please edit the changelog (since IIRC the original AMM PR has already been published)

@mvadari
Copy link
Collaborator

mvadari commented Aug 31, 2023

Please update the changelog.

@khancode khancode changed the title fix: add amm to ledger_entry and account_objects fix: update request models related to AMM Sep 11, 2023
@khancode khancode merged commit c5e9a71 into master Sep 11, 2023
17 checks passed
@khancode khancode deleted the add-amm-ledger-entry-type branch September 11, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvadari mvadari mvadari approved these changes

@JST5000 JST5000 JST5000 approved these changes

@ckniffen ckniffen Awaiting requested review from ckniffen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@khancode @mvadari @ckniffen @JST5000