Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update PR template #641

Merged
merged 1 commit into from
Sep 6, 2023
Merged

docs: Update PR template #641

merged 1 commit into from
Sep 6, 2023

Conversation

JST5000
Copy link
Collaborator

@JST5000 JST5000 commented Sep 6, 2023

High Level Overview of Change

Updating the CHANGELOG is often forgotten by maintainers and external contributors, so we should add it to our PR template.

Context of Change

This should make it easier to contribute to the repo since it's one less back and forth we'll need to message folks about, and make it easier to guarantee our changes are tracked for releases.

Type of Change

  • Documentation Updates

Did you update CHANGELOG.md?

  • No, this change does not impact library users

@ckniffen
Copy link
Collaborator

ckniffen commented Sep 6, 2023

This has already helped me out with my latest PR to xrpl.js

@JST5000 JST5000 merged commit 3fbfff7 into master Sep 6, 2023
17 checks passed
@JST5000 JST5000 deleted the update-pr-template branch September 6, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants