docs: Update theme to ReadTheDocs always (fixes regression) #643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Since 2.2.0, the xrpl-py docs have been loading with a new theme. This brings it back to the previous ReadTheDocs theme.
Context of Change
It seems that the default theme changed without warning (as far as we saw):
Autogenerated theme code from before 2.2.0:
https://readthedocs.org/projects/xrpl-py/builds/21212455/
Autogenerated theme code from versions after/including 2.2.0:
https://readthedocs.org/projects/xrpl-py/builds/21889906/
In general you can check builds and autogenerated theming by going to this build page: https://readthedocs.org/projects/xrpl-py/builds/
Type of Change
Did you update CHANGELOG.md?
Test Plan
Inspection and the docs build locally with the RTD theme ✅
The true efficacy will have to be determined after merging since this is a bug that only shows up in the production docs page, not in the local builds.How it looks after the changes on ReadTheDocs: