RippleAPI: Add data property to error object

XRPLF · Sep 17, 2015 · 0c9aea4 · 0c9aea4
1 parent 778f59b
commit 0c9aea4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/api/common/utils.js b/src/api/common/utils.js
@@ -52,7 +52,7 @@ type Wrapper = (data: any) => any
 function composeAsync(wrapper: Wrapper, callback: Callback): Callback {
   return function(error, data) {
     if (error) {
-      callback(error);
+      callback(error, data);
       return;
     }
     let result;
@@ -66,10 +66,15 @@ function composeAsync(wrapper: Wrapper, callback: Callback): Callback {
   };
 }
 
-function convertErrors(callback: () => void): () => void {
+function convertErrors(callback: Callback): () => void {
   return function(error, data) {
     if (error && !(error instanceof errors.RippleError)) {
-      callback(new errors.RippleError(error));
+      const error_ = new errors.RippleError(error);
+      error_.data = data;
+      callback(error_, data);
+    } else if (error) {
+      error.data = data;
+      callback(error, data);
     } else {
       callback(error, data);
     }

diff --git a/test/api-test.js b/test/api-test.js
@@ -160,6 +160,7 @@ describe('RippleAPI', function() {
       assert(false, 'Should throw RippleError');
     }).catch(error => {
       assert(error instanceof this.api.errors.RippleError);
+      assert(error.data);
     });
   });