Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seed.get_key method does not use account_id #73

Closed
emschwartz opened this issue May 1, 2014 · 1 comment
Closed

Seed.get_key method does not use account_id #73

emschwartz opened this issue May 1, 2014 · 1 comment
Labels
bug

Comments

@emschwartz
Copy link
Contributor

https://github.com/ripple/ripple-lib/blob/develop/src/js/ripple/seed.js#L86

Seed should use the account_id to determine which key to return
@emschwartz emschwartz added the bug label May 1, 2014
sublimator added a commit that referenced this issue May 6, 2014
@sublimator
Seed.get_uses honours account_id. Fix #73
f248852
sublimator added a commit that referenced this issue May 6, 2014
@sublimator
Seed.get_key uses honours account_id. Fix #73
b24ef16
@wltsmrz wltsmrz closed this as completed May 21, 2014
@sublimator
Copy link
Contributor

Did you guys catch the notification reporting a regression the related
patch for this caused? Think it needs looking into.

@sublimator sublimator mentioned this issue May 22, 2014
Closed
sublimator referenced this issue in geertweening/ripple-lib Oct 4, 2014
@geertweening
[FEATURE] make maxLoops in seed.get_key optional
23e473b 
default to 1 or the index of the requested account +1
ledhed2222 pushed a commit that referenced this issue Nov 8, 2021
@intelliot
README: Document functions (#73)
14f9a39
ledhed2222 pushed a commit that referenced this issue Nov 8, 2021
@natenichols
Refactor ./src/enums (#73)
cd0eb2b 
* rewrote enums in TS
* changed folder name to src/definitions
ledhed2222 pushed a commit that referenced this issue Nov 8, 2021
@dependabot-preview
Bump typescript from 3.7.4 to 3.7.5 (#73)
2f17688 
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 3.7.4 to 3.7.5.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v3.7.4...v3.7.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sublimator @wltsmrz @emschwartz