Orders from getOrderbook are not always sorted correctly #766
Comments
|
See this: https://www.xrpchat.com/topic/8223-rippleapi-orderbooks-order-is-by-string-quality/ |
|
Would you like to contribute a PR? 🙂 |
|
Sure. How much are you paying ? |
|
I'm having the same issue, but only with asks Gives the following list makerExchangeRates for asks: It seems like its an ordering issue on the base API of Ripple and not just this library. It should be done on the main API to ensure the real-time data that we receive using this library. |
|
@antondalgren It's a problem of ripple-lib (RippleAPI), because the server returns the book in the correct quality order. |
|
@tuloski Then it should be an easy fix |
|
I have read the code review and the issue which stems from some unnecessary sorting. Personally ripple-lib looks like Homer Simpson's super car which immediately sent his brother into bankruptcy. This is the second time I see something like it (the first one being maxFee param that caused massive XRP bleed and had to be resolved by placing 2XRP hard cap). So I think ripple-lib should not be a front layer on the ledger's API. People should use their own websocket client to connect and communicate while ripple-lib should be turned into a set of helper tools (signing, interpreting low level json response, etc). |
|
@inmyth Good point. We should recommend using |
- Use formatBidsAndAsks with request instead of getOrderbook - Deprecate getOrderbook, which does not sort orders correctly - Resolve #766
I noticed that orders from the function
getOrderbookreturn bids and asks sorted bymakerExchangeRatefrom the lowest to the highest. But some of the orders are sometimes inserted at the wrong sequence, especially if the rate is 0.1. For example this is the order book from following configurationIn the result below, all orders whose rate is exactly 0.1 come first. The ones who rates are smaller (0.027) come later.
{ "bids": [ { "specification": { "direction": "buy", "quantity": { "currency": "XRP", "value": "10900" }, "totalPrice": { "currency": "JPY", "value": "109000", "counterparty": "rB3gZey7VWHYRqJHLoHDEJXJ2pEPNieKiS" } }, "properties": { "maker": "raiY4zsVco3smDCqwjkotnnMELJt1r7yKV", "sequence": 89, "makerExchangeRate": "0.1" } }, { "specification": { "direction": "buy", "quantity": { "currency": "XRP", "value": "2000" }, "totalPrice": { "currency": "JPY", "value": "20000", "counterparty": "rB3gZey7VWHYRqJHLoHDEJXJ2pEPNieKiS" } }, "properties": { "maker": "rnQxjewXW36KsDvdJB92hPrWREdmkuWgjB", "sequence": 151, "makerExchangeRate": "0.1" } }, { "specification": { "direction": "buy", "quantity": { "currency": "XRP", "value": "1000" }, "totalPrice": { "currency": "JPY", "value": "10000", "counterparty": "rB3gZey7VWHYRqJHLoHDEJXJ2pEPNieKiS" } }, "properties": { "maker": "rN4agFYQwcLnAk5X6yYLBapcyrw1FstnWc", "sequence": 52, "makerExchangeRate": "0.1" } }, { "specification": { "direction": "buy", "quantity": { "currency": "XRP", "value": "300" }, "totalPrice": { "currency": "JPY", "value": "3000", "counterparty": "rB3gZey7VWHYRqJHLoHDEJXJ2pEPNieKiS" } }, "properties": { "maker": "r43NZaZCcDrGpYAPEfH7STPLC7xrkszi8Q", "sequence": 264, "makerExchangeRate": "0.1" } }, { "specification": { "direction": "buy", "quantity": { "currency": "XRP", "value": "100" }, "totalPrice": { "currency": "JPY", "value": "1000", "counterparty": "rB3gZey7VWHYRqJHLoHDEJXJ2pEPNieKiS" } }, "properties": { "maker": "rJj72ernMRfLD4kEg6iWnSBEiiJ8jxvFY3", "sequence": 7, "makerExchangeRate": "0.1" } }, { "specification": { "direction": "buy", "quantity": { "currency": "XRP", "value": "50000" }, "totalPrice": { "currency": "JPY", "value": "500000", "counterparty": "rB3gZey7VWHYRqJHLoHDEJXJ2pEPNieKiS" } }, "properties": { "maker": "rJs7cu6c2iAKDKhHbS55qMvVgDYaeUTkwa", "sequence": 284, "makerExchangeRate": "0.1" }, "state": { "fundedAmount": { "currency": "JPY", "value": "0", "counterparty": "rB3gZey7VWHYRqJHLoHDEJXJ2pEPNieKiS" }, "priceOfFundedAmount": { "currency": "XRP", "value": "0" } } }, { "specification": { "direction": "buy", "quantity": { "currency": "XRP", "value": "3000" }, "totalPrice": { "currency": "JPY", "value": "30000", "counterparty": "rB3gZey7VWHYRqJHLoHDEJXJ2pEPNieKiS" } }, "properties": { "maker": "rupaVQe981xcacfrqTaTBijWvD1yT6NQY", "sequence": 5, "makerExchangeRate": "0.1" } }, { "specification": { "direction": "buy", "quantity": { "currency": "XRP", "value": "130.555075" }, "totalPrice": { "currency": "JPY", "value": "4811.566173", "counterparty": "rB3gZey7VWHYRqJHLoHDEJXJ2pEPNieKiS" } }, "properties": { "maker": "rp6XNsJ4at9ArRHLXWnWP8ovRLwhXBUmnt", "sequence": 321471, "makerExchangeRate": "0.02713359232854512" } }, { "specification": { "direction": "buy", "quantity": { "currency": "XRP", "value": "2352.151857" }, "totalPrice": { "currency": "JPY", "value": "86679.14805356543", "counterparty": "rB3gZey7VWHYRqJHLoHDEJXJ2pEPNieKiS" } }, "properties": { "maker": "rDwttW5K5hwftAZKxrYbswvtQXWehEnE4T", "sequence": 7046, "makerExchangeRate": "0.02713630566334699" } }, { "specification": { "direction": "buy", "quantity": { "currency": "XRP", "value": "130.527293" }, "totalPrice": { "currency": "JPY", "value": "4767.105473", "counterparty": "rB3gZey7VWHYRqJHLoHDEJXJ2pEPNieKiS" } }, "properties": { "maker": "rp6XNsJ4at9ArRHLXWnWP8ovRLwhXBUmnt", "sequence": 321469, "makerExchangeRate": "0.02738082757750638" } },Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: